Re: Concatenated URLs should not exceed GET URL size limit (issue3734041)

[pulkitgoyal2000]

http://codereview.appspot.com/3734041/diff/134002/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManagerTest.java
File
java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManagerTest.java
(right):

http://codereview.appspot.com/3734041/diff/134002/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManagerTest.java#newcode133
java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManagerTest.java:133:
if (jsonParams.keySet().contains(uri.getUris().get(0).toString())) {
On 2011/03/07 07:17:26, anupama.dutta wrote:

Assign uri.getUris().get(0).toString() to a variable calle currentUri

for better

readability in this block.

Done.

http://codereview.appspot.com/3734041/diff/134002/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManagerTest.java#newcode324
java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManagerTest.java:324:
uriBasicCheck(concatUris.get(0).getUris().get(0), host, path, 9, type,
"1", "1", versions[0]);
On 2011/03/07 07:17:26, anupama.dutta wrote:

Any idea why we get debug and nocache parameters as "1" here instead

of "0" as

in typeJsBatchSplitBatched?

It is because of trues' used in line 303 for creating mockGadget. As
these values dont matter us, we can choose any value.

http://codereview.appspot.com/3734041/diff/134002/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManagerTest.java#newcode380
java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManagerTest.java:380:
private void uriBasicCheck(Uri uri,
On 2011/03/07 07:17:26, anupama.dutta wrote:

uriBasicCheck -> verifyBasicUriParameters or checkBasicUriParameters.

Done.

http://codereview.appspot.com/3734041/diff/134002/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManagerTest.java#newcode381
java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManagerTest.java:381:
String host,
On 2011/03/07 07:17:26, anupama.dutta wrote:

Fix indentation for this line and the next few lines.

Done.

http://codereview.appspot.com/3734041/diff/134002/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManagerTest.java#newcode401
java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManagerTest.java:401:
private void uriBasicCheck(Uri uri,
On 2011/03/07 07:17:26, anupama.dutta wrote:

uriBasicCheck -> verifyBasicUriParameters or checkBasicUriParameters.

Done.

http://codereview.appspot.com/3734041/