http://codereview.appspot.com/3082041/diff/192001/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BaseOptimizer.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BaseOptimizer.java (right):
http://codereview.appspot.com/3082041/diff/192001/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BaseOptimizer.java#newcode77 java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BaseOptimizer.java:77: this.sourceImageParams = sourceImageParams; On 2011/02/02 19:27:49, gagan.goku wrote:
why not add sourceImageParams param to the constructor? or add a new constructor which takes in sourceImageParams, and call initializeOutputter from both constructors. and get rid of extra calls to getOutputter() in the functions below.
Done. http://codereview.appspot.com/3082041/diff/192001/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/JPEGOptimizer.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/JPEGOptimizer.java (right): http://codereview.appspot.com/3082041/diff/192001/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/JPEGOptimizer.java#newcode37 java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/JPEGOptimizer.java:37: On 2011/02/02 19:27:49, gagan.goku wrote:
remove extra sapce
Done. http://codereview.appspot.com/3082041/diff/192001/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/OptimizerConfig.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/OptimizerConfig.java (right): http://codereview.appspot.com/3082041/diff/192001/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/OptimizerConfig.java#newcode112 java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/OptimizerConfig.java:112: public boolean getJpegRetainSubsampling() { On 2011/02/02 19:27:49, gagan.goku wrote:
fix indentation
Done. http://codereview.appspot.com/3082041/
