LGTM

http://codereview.appspot.com/3082041/diff/204004/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BaseOptimizer.java
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BaseOptimizer.java
(right):

http://codereview.appspot.com/3082041/diff/204004/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BaseOptimizer.java#newcode68
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BaseOptimizer.java:68:
protected JpegImageUtils.JpegImageParams sourceImageParams;
make this final

http://codereview.appspot.com/3082041/diff/204004/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BasicImageRewriter.java
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BasicImageRewriter.java
(right):

http://codereview.appspot.com/3082041/diff/204004/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BasicImageRewriter.java#newcode309
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BasicImageRewriter.java:309:
jpegImageParams =
JpegImageUtils.getJpegImageData(response.getContentBytes(),
uri.getPath());
100 chars

http://codereview.appspot.com/3082041/

Reply via email to