Thats odd John. I checkout a fresh version of Shindig from SVN, applied the patch from the code review and built everything and everything built fine. Any details on what the failure is? [INFO] Apache Shindig Project ............................ SUCCESS [7.157s] [INFO] Apache Shindig Features ........................... SUCCESS [28.718s] [INFO] Apache Shindig Common Code ........................ SUCCESS [17.880s] [INFO] Apache Shindig Gadget Renderer .................... SUCCESS [39.610s] [INFO] Apache Shindig Social API ......................... SUCCESS [17.006s] [INFO] Apache Shindig Extra Modules ...................... SUCCESS [4.847s] [INFO] Apache Shindig Web App ............................ SUCCESS [34.333s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 2:31.308s [INFO] Finished at: Tue May 03 20:39:24 EDT 2011 [INFO] Final Memory: 15M/81M [INFO] ------------------------------------------------------------------------
On 2011/05/03 20:19:55, johnfargo wrote:
Hi Ryan,
I was trying to do so, but found that EndToEndTest still fails for me.
Thoughts?
Failed tests: jsonParse(org.apache.shindig.server.endtoend.EndToEndTest): test
method
jsonConvertXmlToJsonTest did not finish
--j
On 2011/05/03 12:34:21, http://rjbaxter_us.ibm.com wrote: > Could someone please complete this code review for me and deliver
the
> code? This issue has been open for a while and I have had trouble
finding
> someone to finish the code review and deliver the code. Thanks. > > -Ryan > > Email: mailto:[email protected] > Phone: 978-899-3041 > developerWorks Profile > > > > From: mailto:[email protected] > To: mailto:[email protected], mailto:[email protected], > Cc: mailto:[email protected] > Date: 04/29/2011 11:24 AM > Subject: Re: Add the ability to translate arbritary XML into
JSON
> (issue4438071) > > > > John when you get a chance could you review my updated changes?
Thanks!
> > On 2011/04/27 14:41:27, rbaxter85 wrote: > > Updated patch with John's Suggestions > > > > http://codereview.appspot.com/4438071/ > > >
http://codereview.appspot.com/4438071/
