Matt had a good suggestion but after we talked today we concluded that it can't be the problem you are seeing John. I am compiling shindig with Java 1.5 and Matt applied the patch today and built it with 1.6 and all the tests pass on his machine as well. Could you give more details on what test is failing John? I know its kind of a pain to do.....but I am not really sure why the tests are failing in your environment.
I also uploaded an updated patch based on a bug I found today. -Ryan Email: [email protected] Phone: 978-899-3041 developerWorks Profile From: Matthew G Marum/Raleigh/IBM@IBMUS To: [email protected], Cc: [email protected], Ryan J Baxter/Westford/IBM@Lotus Date: 05/04/2011 01:37 PM Subject: Re: Add the ability to translate arbritary XML into JSON (issue4438071) I haven't had a chance to try it, but could it be a JRE related issue? Matt rbaxter85---05/03/2011 08:51:03 PM---Thats odd John. I checkout a fresh version of Shindig from SVN, applied the patch from the code rev From: [email protected] To: [email protected], [email protected], Ryan J Baxter/Westford/IBM@Lotus Cc: [email protected] Date: 05/03/2011 08:51 PM Subject: Re: Add the ability to translate arbritary XML into JSON (issue4438071) Thats odd John. I checkout a fresh version of Shindig from SVN, applied the patch from the code review and built everything and everything built fine. Any details on what the failure is? [INFO] Apache Shindig Project ............................ SUCCESS [7.157s] [INFO] Apache Shindig Features ........................... SUCCESS [28.718s] [INFO] Apache Shindig Common Code ........................ SUCCESS [17.880s] [INFO] Apache Shindig Gadget Renderer .................... SUCCESS [39.610s] [INFO] Apache Shindig Social API ......................... SUCCESS [17.006s] [INFO] Apache Shindig Extra Modules ...................... SUCCESS [4.847s] [INFO] Apache Shindig Web App ............................ SUCCESS [34.333s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 2:31.308s [INFO] Finished at: Tue May 03 20:39:24 EDT 2011 [INFO] Final Memory: 15M/81M [INFO] ------------------------------------------------------------------------ On 2011/05/03 20:19:55, johnfargo wrote: > Hi Ryan, > I was trying to do so, but found that EndToEndTest still fails for me. Thoughts? > Failed tests: > jsonParse(org.apache.shindig.server.endtoend.EndToEndTest): test method > jsonConvertXmlToJsonTest did not finish > --j > On 2011/05/03 12:34:21, http://rjbaxter_us.ibm.com wrote: > > Could someone please complete this code review for me and deliver the > > code? This issue has been open for a while and I have had trouble finding > > someone to finish the code review and deliver the code. Thanks. > > > > -Ryan > > > > Email: mailto:[email protected] > > Phone: 978-899-3041 > > developerWorks Profile > > > > > > > > From: mailto:[email protected] > > To: mailto:[email protected], mailto:[email protected], > > Cc: mailto:[email protected] > > Date: 04/29/2011 11:24 AM > > Subject: Re: Add the ability to translate arbritary XML into JSON > > (issue4438071) > > > > > > > > John when you get a chance could you review my updated changes? Thanks! > > > > On 2011/04/27 14:41:27, rbaxter85 wrote: > > > Updated patch with John's Suggestions > > > > > > > > http://codereview.appspot.com/4438071/ > > > > > > http://codereview.appspot.com/4438071/
