> On 2011-05-27 12:19:11, Stanton Sievers wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/config/container.js, line 106 > > <https://reviews.apache.org/r/792/diff/1/?file=19745#file19745line106> > > > > These changes in container.js concern me. %host% and ${SERVER_HOST} > > are not synonymous. > > > > In what types of deployments have you tested this? I think this is > > going to break some things in environments where the container and the > > server are on separate domains. > > > > In most cases %host% is substituted for document.location.host at > > runtime while ${SERVER_HOST} should come from the web.xml
Two properties in container.js are changed: "defaultShindigTestHost" and "defaultShindigProxyConcatAuthority". Both are resolved on the server side and does take values from web.xml. some javascript features are using "%host%", I could change "%host%" to "%authority%" for above two properties to eliminate the confusion. thoughts? didn't test separate domain usecase... but don't think it's affected since properties are resolved on server. - li ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/792/#review726 ----------------------------------------------------------- On 2011-05-26 21:39:40, li xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/792/ > ----------------------------------------------------------- > > (Updated 2011-05-26 21:39:40) > > > Review request for shindig. > > > Summary > ------- > > This is a follow up for Issue 1534: > https://issues.apache.org/jira/browse/SHINDIG-1534 > > As discussed, default AuthorityProvider would implement following logic with > a Provider pattern > > 1. shindig.host & shindig.port defined in web.xml or system property > 2. host/port from HttpServletRequest > 3. Jetty host/port > > link to JIRA: https://issues.apache.org/jira/browse/SHINDIG-1541 > > > Diffs > ----- > > http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1125049 > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java > 1125049 > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/Authority.java > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/AuthorityProvider.java > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthority.java > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/ServletRequestContext.java > 1124991 > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/common/servlet/AuthorityProviderTest.java > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java > 1124991 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManager.java > 1126359 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java > 1124991 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java > 1124991 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java > 1126359 > > http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/webapp/WEB-INF/web.xml > 1124991 > > Diff: https://reviews.apache.org/r/792/diff > > > Testing > ------- > > > Thanks, > > li > >
