----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/792/ -----------------------------------------------------------
(Updated 2011-06-06 14:45:37.546647) Review request for shindig. Changes ------- Updated with Henry's comments. thanks. Summary ------- This is a follow up for Issue 1534: https://issues.apache.org/jira/browse/SHINDIG-1534 As discussed, default AuthorityProvider would implement following logic with a Provider pattern 1. shindig.host & shindig.port defined in web.xml or system property 2. host/port from HttpServletRequest 3. Jetty host/port link to JIRA: https://issues.apache.org/jira/browse/SHINDIG-1541 Diffs (updated) ----- http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1127686 http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java 1127686 http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/Authority.java PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthority.java PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthorityProvider.java PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/ServletRequestContext.java 1127686 http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/common/servlet/BasicAuthorityProviderTest.java PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java 1127686 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManager.java 1127686 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java 1127686 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java 1127686 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java 1127686 http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/webapp/WEB-INF/web.xml 1127686 Diff: https://reviews.apache.org/r/792/diff Testing ------- built, passed unit tests. tested with /samplecontainer/examples/commoncontainer/index.html Thanks, li
