----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/983/#review946 -----------------------------------------------------------
Ship it! LGTM - Stanton On 2011-06-30 14:51:09, Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/983/ > ----------------------------------------------------------- > > (Updated 2011-06-30 14:51:09) > > > Review request for shindig. > > > Summary > ------- > > Change to return first descendant iframe element instead of just firstChild. > > > This addresses bug SHINDIG-1554. > https://issues.apache.org/jira/browse/SHINDIG-1554 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/gadget_holder.js > 1137018 > > Diff: https://reviews.apache.org/r/983/diff > > > Testing > ------- > > Tested in example container using a gadget with pubsub-2 feature. > > > Thanks, > > Dan > >
