----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/983/#review1054 -----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js <https://reviews.apache.org/r/983/#comment2133> I just noticed that in the 2nd revision of your patch that you changed "getElement" instead of "getIframeElement". Seems to be a bug in the 2nd patch. - Stanton On 2011-07-01 23:02:11, Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/983/ > ----------------------------------------------------------- > > (Updated 2011-07-01 23:02:11) > > > Review request for shindig. > > > Summary > ------- > > Change to return first descendant iframe element instead of just firstChild. > > > This addresses bug SHINDIG-1554. > https://issues.apache.org/jira/browse/SHINDIG-1554 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js > 1142113 > > Diff: https://reviews.apache.org/r/983/diff > > > Testing > ------- > > Tested in example container using a gadget with pubsub-2 feature. > > > Thanks, > > Dan > >
