----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1029/#review1005 -----------------------------------------------------------
Isnt this fix reverse the change for https://issues.apache.org/jira/browse/SHINDIG-1503? - Henry On 2011-07-08 05:29:55, Sumedha Kodithuwakku wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1029/ > ----------------------------------------------------------- > > (Updated 2011-07-08 05:29:55) > > > Review request for shindig, Ryan Baxter and Agustin Casiva. > > > Summary > ------- > > Although the OAuth consumer details are properly inserted into the oauth.json > file, when running an example OAuth gadget in the sample container the > following error comes out. This is happening in the current trunk revision > and it works fine with 2.0.0 release. > > "Something went wrong: Could not fetch gadget spec ==== Original request: GET > /m8/feeds/contacts/default/base?alt=json Host: www.google.com > X-Shindig-AuthType: oauth X-Forwarded-For: 0:0:0:0:0:0:0:1 X-shindig-dos: on > ====" > > Modified the createToken() method in CommonContainerSecurityTokenCodec to use > the codec which has been created already. > > Link to JIRA Issue : https://issues.apache.org/jira/browse/SHINDIG-1556 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/java/org/apache/shindig/sample/commoncontainer/auth/CommonContainerSecurityTokenCodec.java > 1142914 > > Diff: https://reviews.apache.org/r/1029/diff > > > Testing > ------- > > Tested with two OAuth gadgets. Need more testing. > > > Thanks, > > Sumedha > >
