oops, forgot about these comments.. plz ignore if they're no longer
relevant.

Otherwise looking good, will try to peek at this again later today.



http://codereview.appspot.com/4631090/diff/11001/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js
File
features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js
(right):

http://codereview.appspot.com/4631090/diff/11001/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js#newcode28
features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js:28:
/**
looks like the indent went to three here.  Can you move it to 2?

http://codereview.appspot.com/4631090/diff/11001/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js#newcode34
features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js:34:
* @param {function} optional callback function
rename to opt_callback and use {function=} jsdoc.

http://codereview.appspot.com/4631090/diff/11001/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js#newcode53
features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js:53:
* @param {object} renderParams params to augment the rendering.
uppercase object

http://codereview.appspot.com/4631090/diff/11001/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js#newcode133
features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js:133:
}
nit: spacing

http://codereview.appspot.com/4631090/

Reply via email to