Updated patch and moved code review to the apache code review tool.
https://reviews.apache.org/r/1085/
http://codereview.appspot.com/4631090/diff/11001/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js
File
features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js
(right):
http://codereview.appspot.com/4631090/diff/11001/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js#newcode28
features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js:28:
/**
On 2011/07/11 16:05:34, Paul Lindner wrote:
looks like the indent went to three here. Can you move it to 2?
Done.
http://codereview.appspot.com/4631090/diff/11001/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js#newcode34
features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js:34:
* @param {function} optional callback function
Actually the function doesn''t even take in a function, so I removed it
completely.
On 2011/07/11 16:05:34, Paul Lindner wrote:
rename to opt_callback and use {function=} jsdoc.
http://codereview.appspot.com/4631090/diff/11001/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js#newcode53
features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js:53:
* @param {object} renderParams params to augment the rendering.
On 2011/07/11 16:05:34, Paul Lindner wrote:
uppercase object
Done.
http://codereview.appspot.com/4631090/diff/11001/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js#newcode133
features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js:133:
}
On 2011/07/11 16:05:34, Paul Lindner wrote:
nit: spacing
Done.
http://codereview.appspot.com/4631090/
