----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1079/#review1026 -----------------------------------------------------------
trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/js/JsLoadProcessor.java <https://reviews.apache.org/r/1079/#comment2105> Is the defined http: here intentional? I would have thought that keeping it protocol-relative, the same as the document.write() version, would be better. - Mat On 2011-07-11 19:04:04, johnfargo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1079/ > ----------------------------------------------------------- > > (Updated 2011-07-11 19:04:04) > > > Review request for shindig. > > > Summary > ------- > > Allows Boolean configuration value "shindig.jsload.async-mode" to be set. > When true, an element.appendChild(srcElem) based approach is taken for > &jsload=1 rather than document.write. > > This functionality is not enabled by default. > > > Diffs > ----- > > > trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/js/JsLoadProcessor.java > 1144361 > > Diff: https://reviews.apache.org/r/1079/diff > > > Testing > ------- > > > Thanks, > > johnfargo > >
