----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1190/#review1196 -----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js <https://reviews.apache.org/r/1190/#comment2605> You can simplify this if else a little. var result = {'width' : -1, 'height': -1}; if(el !== undefined){ result.width = el.clientWidth; result.height = el.clientHeight; } resultCallback(callback); - Ryan On 2011-07-26 14:23:13, Jason Chiang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1190/ > ----------------------------------------------------------- > > (Updated 2011-07-26 14:23:13) > > > Review request for shindig and Ryan Baxter. > > > Summary > ------- > > > 1. Update implementation of gadgets.window.getContainerDimensions based on > latest API which will call the callback function with the dimension object as > parameter. > 2. correct the feature signature/docs. > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js > 1150848 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js > 1150848 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js > 1150704 > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/media-openGadgets/MediaUIOpenGadgets.js > 1150846 > > Diff: https://reviews.apache.org/r/1190/diff > > > Testing > ------- > > > Thanks, > > Jason > >
