> On 2011-08-12 00:37:02, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js, > > line 223 > > <https://reviews.apache.org/r/1476/diff/2/?file=32304#file32304line223> > > > > Maybe I should have looked at this functionality earlier but I am > > struggling to grasp this 'listener' functionality to get the preferences > > when navigating to the gadget. Why wouldn't the container get the > > preferences before they call navigate gadget and just stick them in > > renderParams when calling navigateGadget?
I agree with Ryan's comment -- this doesn't seem like it should be necessary. We actually use the approach Ryan is describing already in Rave and I can confirm that it works just fine. - Jesse ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1476/#review1413 ----------------------------------------------------------- On 2011-08-11 23:35:43, Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1476/ > ----------------------------------------------------------- > > (Updated 2011-08-11 23:35:43) > > > Review request for shindig. > > > Summary > ------- > > Spec Change: > http://code.google.com/p/opensocial-resources/issues/detail?id=1203 > > Change the GET_PREFERENCES api to be asynchronous > > > This addresses bug SHINDIG-1568. > https://issues.apache.org/jira/browse/SHINDIG-1568 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js > 1156829 > > Diff: https://reviews.apache.org/r/1476/diff > > > Testing > ------- > > > Thanks, > > Dan > >
