> On 2011-08-12 00:37:02, Ryan Baxter wrote: > > > > Dan Dumont wrote: > The spec declared the 2 common container config params (set/get) to be > optional. It's not necessary to use them. > However, since fetching preferences is such a common task for containers > it seemed nice to provide this optional convenience to containers. > > I did not want to make it mandatory, so you'll note that if you supply > the preferences in the renderParams, they will be used instead. > > Ryan Baxter wrote: > Ok I can buy that, as long as its up to the container to decide what it > wants to do I am fine with providing both methods. Jesse, does this sound OK > to you?
Yes -- sounds good to me too. I didn't realize a formal spec had actually been written around the common container, that's great to see. I knew there were some discussions of it but I hadn't actually seen it yet. Now that I've read over the spec a bit this makes more sense to me. - Jesse ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1476/#review1413 ----------------------------------------------------------- On 2011-08-11 23:35:43, Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1476/ > ----------------------------------------------------------- > > (Updated 2011-08-11 23:35:43) > > > Review request for shindig. > > > Summary > ------- > > Spec Change: > http://code.google.com/p/opensocial-resources/issues/detail?id=1203 > > Change the GET_PREFERENCES api to be asynchronous > > > This addresses bug SHINDIG-1568. > https://issues.apache.org/jira/browse/SHINDIG-1568 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js > 1156829 > > Diff: https://reviews.apache.org/r/1476/diff > > > Testing > ------- > > > Thanks, > > Dan > >
