> On 2011-09-16 18:47:49, Stanton Sievers wrote: > > Do you know who is taking the initiative to implement the usage of "method" > > in Shindig?
Not sure, its a community project so anyone could just do it. > On 2011-09-16 18:47:49, Stanton Sievers wrote: > > trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/LinkSpec.java, > > line 74 > > <https://reviews.apache.org/r/1928/diff/2/?file=41488#file41488line74> > > > > Is there a particular reason getMethod() isn't being added to > > GadgetsHandlerApi.LinkSpec? No reason other than forget cause its too many duplicate classes for different purpose =( I will add it in the code. - Henry ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1928/#review1936 ----------------------------------------------------------- On 2011-09-16 18:16:57, Henry Saputra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1928/ > ----------------------------------------------------------- > > (Updated 2011-09-16 18:16:57) > > > Review request for shindig. > > > Summary > ------- > > The <Link> representation LinkSpec class missing "method" optional property > as defined in the OpenSocial specs: > http://opensocial-resources.googlecode.com/svn/spec/2.0/Core-Gadget.xml#LifeCycleEvents > > > This addresses bug SHINDIG-1622. > https://issues.apache.org/jira/browse/SHINDIG-1622 > > > Diffs > ----- > > > trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/LinkSpec.java > 1171202 > > trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/spec/LinkSpecTest.java > 1171202 > > Diff: https://reviews.apache.org/r/1928/diff > > > Testing > ------- > > Updated the unit test for LinkSpec and pass. > > > Thanks, > > Henry > >
