----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1928/#review1947 -----------------------------------------------------------
Ship it! One more thing to consider then this LGTM. trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/LinkSpec.java <https://reviews.apache.org/r/1928/#comment4428> The spec says the value can be either "POST" or "GET". This implementation allows it to be anything. It could be left up to the implementor to sanitize the inputs or it could be done here. I don't feel strongly either way, just wanted to bring it up. - Stanton On 2011-09-16 19:53:07, Henry Saputra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1928/ > ----------------------------------------------------------- > > (Updated 2011-09-16 19:53:07) > > > Review request for shindig. > > > Summary > ------- > > The <Link> representation LinkSpec class missing "method" optional property > as defined in the OpenSocial specs: > http://opensocial-resources.googlecode.com/svn/spec/2.0/Core-Gadget.xml#LifeCycleEvents > > > This addresses bug SHINDIG-1622. > https://issues.apache.org/jira/browse/SHINDIG-1622 > > > Diffs > ----- > > > trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java > 1171202 > > trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/LinkSpec.java > 1171202 > > trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/spec/LinkSpecTest.java > 1171202 > > Diff: https://reviews.apache.org/r/1928/diff > > > Testing > ------- > > Updated the unit test for LinkSpec and pass. > > > Thanks, > > Henry > >
