> On 2011-09-18 05:30:27, Murali VP wrote: > > By adding new XML elements this change affects the XML schema of gadgets. > > Please provide/publish an updated XSD that a gadget that includes the new > > elements can validate against. > > An alternative would be introduce a special namespace for the new elements > > so that the XML will remain backward compatible.
Murali, that's a good point. We have a proposal to open social gadget spec about the new elements that's added. Right now the proposal doesn't include gadget xml schema updates. Will update that soon. You may see the link here: http://code.google.com/p/opensocial-resources/issues/detail?id=1209 - li ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1947/#review1958 ----------------------------------------------------------- On 2011-09-17 13:54:52, li xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1947/ > ----------------------------------------------------------- > > (Updated 2011-09-17 13:54:52) > > > Review request for shindig. > > > Summary > ------- > > OAuth 2.0 client implementation in Apache Shindig from Adam Clarke, Eric > Woods, Jeff Hoy, Li Xu and Matthew Marum. > > > Documentation wiki: > http://docs.opensocial.org/display/OSD/OAuth+2.0+Consumer+Implementation+in+Apache+Shindig > > > JIRA issue: https://issues.apache.org/jira/browse/SHINDIG-1624 > > OAuth2 test gadgets are added to common container test page and can be tested > by using > http://localhost:8080/samplecontainer/examples/commoncontainer/index.html > > You will need OAuth2 service provider implementation to test following two > gadgets: > OAuth2 demo with Shindig Provider (Authorization Code) > OAuth2 demo with Shindig Provider (Client credential ) > > You will need to have your own google/facebook client to test following two > gadgets > OAuth2 demo with Google Provider > OAuth2 demo with Facebook Provider > Once it's registered with Google/Facebook, you can register the client-id/pwd > under > /config/oauth2.json > > > This addresses bug shindig-1624. > https://issues.apache.org/jira/browse/shindig-1624 > > > Diffs > ----- > > /trunk/config/oauth2.json PRE-CREATION > > /trunk/content/samplecontainer/examples/commoncontainer/gadgetCollections.json > 1162113 > /trunk/content/samplecontainer/examples/oauth2/oauth2_facebook.xml > PRE-CREATION > /trunk/content/samplecontainer/examples/oauth2/oauth2_google.xml > PRE-CREATION > /trunk/content/samplecontainer/examples/oauth2/shindig_authorization.xml > PRE-CREATION > > /trunk/content/samplecontainer/examples/oauth2/shindig_client_credentials.xml > PRE-CREATION > /trunk/content/sampledata/canonicaldb.json 1162113 > /trunk/features/src/main/javascript/features/core.io/io.js 1162113 > > /trunk/features/src/main/javascript/features/shindig.xhrwrapper/xhrwrapper.js > 1162113 > /trunk/java/common/conf/shindig.properties 1162113 > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AuthType.java > 1162113 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/config/XhrwrapperConfigContributor.java > 1162113 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java > 1162113 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultInvalidationService.java > 1162113 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultRequestPipeline.java > 1162113 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java > 1162113 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthProtocolException.java > 1162113 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Accessor.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Request.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/GadgetOAuth2TokenStore.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Accessor.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Arguments.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Error.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2FetcherConfig.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2GadgetContext.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Message.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Module.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Request.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2RequestException.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2ResponseParams.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Store.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Token.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Utils.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/AuthorizationEndpointResponseHandler.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/ClientAuthenticationHandler.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/GrantRequestHandler.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/ResourceRequestHandler.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/TokenEndpointResponseHandler.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/BasicAuthenticationHandler.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/BearerTokenHandler.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/ClientCredentialsGrantTypeHandler.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/CodeAuthorizationResponseHandler.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/CodeGrantTypeHandler.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/OAuth2HandlerModule.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/TokenAuthorizationResponseHandler.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Cache.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2CacheException.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Encrypter.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2EncryptionException.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2PersistenceException.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Persister.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2TokenPersistence.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/InMemoryCache.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/NoOpEncrypter.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/OAuth2GadgetBinding.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/OAuth2PersistenceModule.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/OAuth2Provider.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/sample/BasicOAuth2Message.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/sample/OAuth2MessageModule.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/preload/HttpPreloader.java > 1162113 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/ProxyRenderer.java > 1162113 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HttpRequestHandler.java > 1162113 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java > 1162113 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/OAuth2CallbackServlet.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/OAuthCallbackServlet.java > 1162113 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/ModulePrefs.java > 1162113 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/OAuth2Service.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/OAuth2Spec.java > PRE-CREATION > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/AuthTypeTest.java > 1162113 > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/DefaultInvalidationService.java > PRE-CREATION > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/DefaultInvalidationServiceTest.java > 1162113 > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/DefaultRequestPipelineTest.java > 1162113 > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/RewriteModuleTest.java > 1162113 > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/StyleTagProxyEmbeddedUrlsVisitorTest.java > 1162113 > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/tags/TemplateBasedTagHandlerTest.java > 1162113 > /trunk/java/server/pom.xml 1162113 > /trunk/java/server/src/main/webapp/WEB-INF/web.xml 1162113 > > /trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndServer.java > 1157240 > > Diff: https://reviews.apache.org/r/1947/diff > > > Testing > ------- > > Yes, passed all JUnit tests with mantis build. tested with new OAuth2 demo > pages. > > > Thanks, > > li > >
