> On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2RequestException.java, > > line 24 > > <https://reviews.apache.org/r/1947/diff/3/?file=45539#file45539line24> > > > > Make sure the javadoc is complete
agreed > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2ResponseParams.java, > > line 34 > > <https://reviews.apache.org/r/1947/diff/3/?file=45540#file45540line34> > > > > Make sure the javadoc is complete agreed > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2ResponseParams.java, > > line 91 > > <https://reviews.apache.org/r/1947/diff/3/?file=45540#file45540line91> > > > > Should use a StringBuffer agreed,replaced with StringBuilder. > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Store.java, > > line 133 > > <https://reviews.apache.org/r/1947/diff/3/?file=45541#file45541line133> > > > > what does this return? fixed > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Token.java, > > line 32 > > <https://reviews.apache.org/r/1947/diff/3/?file=45542#file45542line32> > > > > Make sure the javadoc is complete agreed > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Utils.java, > > line 66 > > <https://reviews.apache.org/r/1947/diff/3/?file=45543#file45543line66> > > > > Use the Maps API done > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Utils.java, > > line 69 > > <https://reviews.apache.org/r/1947/diff/3/?file=45543#file45543line69> > > > > Should we check the list's size before accessing any of the elements in > > it? done > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Utils.java, > > line 76 > > <https://reviews.apache.org/r/1947/diff/3/?file=45543#file45543line76> > > > > Should we check the list's size before accessing any of the elements in > > it? done > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Utils.java, > > line 156 > > <https://reviews.apache.org/r/1947/diff/3/?file=45543#file45543line156> > > > > Log this exception done > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/AuthorizationEndpointResponseHandler.java, > > line 39 > > <https://reviews.apache.org/r/1947/diff/3/?file=45544#file45544line39> > > > > Make sure the javadoc is complete agreed > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/ClientAuthenticationHandler.java, > > line 36 > > <https://reviews.apache.org/r/1947/diff/3/?file=45545#file45545line36> > > > > Make sure the javadoc is complete agreed > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/GrantRequestHandler.java, > > line 35 > > <https://reviews.apache.org/r/1947/diff/3/?file=45546#file45546line35> > > > > Make sure the javadoc is complete agreed > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/OAuth2HandlerError.java, > > line 28 > > <https://reviews.apache.org/r/1947/diff/3/?file=45547#file45547line28> > > > > Make sure the javadoc is complete agreed > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/ResourceRequestHandler.java, > > line 35 > > <https://reviews.apache.org/r/1947/diff/3/?file=45548#file45548line35> > > > > Make sure the javadoc is complete agreed > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/TokenEndpointResponseHandler.java, > > line 32 > > <https://reviews.apache.org/r/1947/diff/3/?file=45549#file45549line32> > > > > Make sure the javadoc is complete agreed > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/BearerTokenHandler.java, > > line 73 > > <https://reviews.apache.org/r/1947/diff/3/?file=45551#file45551line73> > > > > Use the Maps API done > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/ClientCredentialsGrantTypeHandler.java, > > line 56 > > <https://reviews.apache.org/r/1947/diff/3/?file=45552#file45552line56> > > > > Use the Maps API done > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/CodeAuthorizationResponseHandler.java, > > line 69 > > <https://reviews.apache.org/r/1947/diff/3/?file=45553#file45553line69> > > > > Use the Maps API done > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/CodeGrantTypeHandler.java, > > line 48 > > <https://reviews.apache.org/r/1947/diff/3/?file=45554#file45554line48> > > > > Use the Maps API done > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/MACTokenHandler.java, > > line 145 > > <https://reviews.apache.org/r/1947/diff/3/?file=45555#file45555line145> > > > > NIT: Might help to have a helper class for this to make this code > > cleaner split the function into a seperate function to make it more readable... the header string is unique to Mac token type. > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Utils.java, > > line 38 > > <https://reviews.apache.org/r/1947/diff/3/?file=45543#file45543line38> > > > > Does this belong in the commons project? > > Make sure the javadoc is complete OAuth2 consumer specific utility. agreed. > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/sample/BasicOAuth2Message.java, > > line 186 > > <https://reviews.apache.org/r/1947/diff/3/?file=45573#file45573line186> > > > > Not sure we want to call out facebook removed > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/OAuth2CallbackServlet.java, > > line 132 > > <https://reviews.apache.org/r/1947/diff/3/?file=45579#file45579line132> > > > > Could you break here after you set foundHandler to true fixed > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java, > > line 95 > > <https://reviews.apache.org/r/1947/diff/3/?file=45568#file45568line95> > > > > Want to log these exceptions done > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java, > > line 200 > > <https://reviews.apache.org/r/1947/diff/3/?file=45568#file45568line200> > > > > Remove this done > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java, > > line 248 > > <https://reviews.apache.org/r/1947/diff/3/?file=45568#file45568line248> > > > > Remove this done > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java, > > line 304 > > <https://reviews.apache.org/r/1947/diff/3/?file=45568#file45568line304> > > > > Remove this done > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/OAuth2GadgetBinding.java, > > line 23 > > <https://reviews.apache.org/r/1947/diff/3/?file=45570#file45570line23> > > > > Add Javadoc agreed > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/OAuth2Provider.java, > > line 25 > > <https://reviews.apache.org/r/1947/diff/3/?file=45572#file45572line25> > > > > Add Javadoc agreed > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/OAuth2CallbackServlet.java, > > line 182 > > <https://reviews.apache.org/r/1947/diff/3/?file=45579#file45579line182> > > > > Would it be better to just have a constructor where there are injected > > instead of just having the default constructor? servlet spec requires configuration being done in init() thus can't handle constructor injection for servlet. please see comments in InjectedServlet. > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/OAuth2Service.java, > > line 40 > > <https://reviews.apache.org/r/1947/diff/3/?file=45581#file45581line40> > > > > Make sure Javadoc is complete > > Is there any code we can share between the OAuth2 service and the > > OAuth1 service? agreed about javadoc. created BaseOAuthService. > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/OAuth2Spec.java, > > line 36 > > <https://reviews.apache.org/r/1947/diff/3/?file=45582#file45582line36> > > > > Make sure the Javadoc is complete > > Can we share any code between the OAuth2 spec and the OAuth1 spec? agreed about javadoc. need to be unique to different service: OAuthService or OAuth2Service. > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Cache.java, > > line 31 > > <https://reviews.apache.org/r/1947/diff/3/?file=45559#file45559line31> > > > > Make sure javadoc is complete agreed > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java, > > line 33 > > <https://reviews.apache.org/r/1947/diff/3/?file=45561#file45561line33> > > > > Make sure the javadoc is complete agreed > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Encrypter.java, > > line 27 > > <https://reviews.apache.org/r/1947/diff/3/?file=45562#file45562line27> > > > > Make sure the javadoc is compelte agreed > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Persister.java, > > line 41 > > <https://reviews.apache.org/r/1947/diff/3/?file=45565#file45565line41> > > > > Make sure the javadoc is complete agreed > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/TokenAuthorizationResponseHandler.java, > > line 76 > > <https://reviews.apache.org/r/1947/diff/3/?file=45558#file45558line76> > > > > Is the spec vague about the content type? Why does Facebook and Google > > have two different content types? spec is not vague, however Facebook seems behind the spec. > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/MACTokenHandler.java, > > line 197 > > <https://reviews.apache.org/r/1947/diff/3/?file=45555#file45555line197> > > > > NIT: There are alot of params here, consider making a POJO object and > > passing that in. agreed - li ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1947/#review2092 ----------------------------------------------------------- On 2011-10-12 14:52:23, li xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1947/ > ----------------------------------------------------------- > > (Updated 2011-10-12 14:52:23) > > > Review request for shindig. > > > Summary > ------- > > OAuth 2.0 client implementation in Apache Shindig from Adam Clarke, Eric > Woods, Jeff Hoy, Li Xu and Matthew Marum. > > > Documentation wiki: > http://docs.opensocial.org/display/OSD/OAuth+2.0+Consumer+Implementation+in+Apache+Shindig > > > JIRA issue: https://issues.apache.org/jira/browse/SHINDIG-1624 > > OAuth2 test gadgets are added to common container test page and can be tested > by using > http://localhost:8080/samplecontainer/examples/commoncontainer/index.html > > You will need OAuth2 service provider implementation to test following two > gadgets: > OAuth2 demo with Shindig Provider (Authorization Code) > OAuth2 demo with Shindig Provider (Client credential ) > > You will need to have your own google/facebook client to test following two > gadgets > OAuth2 demo with Google Provider > OAuth2 demo with Facebook Provider > Once it's registered with Google/Facebook, you can register the client-id/pwd > under > /config/oauth2.json > > > This addresses bug shindig-1624. > https://issues.apache.org/jira/browse/shindig-1624 > > > Diffs > ----- > > /trunk/config/oauth2.json PRE-CREATION > > /trunk/content/samplecontainer/examples/commoncontainer/gadgetCollections.json > 1182008 > /trunk/content/samplecontainer/examples/oauth2/oauth2_facebook.xml > PRE-CREATION > /trunk/content/samplecontainer/examples/oauth2/oauth2_google.xml > PRE-CREATION > /trunk/content/samplecontainer/examples/oauth2/oauth2_windowslive.xml > PRE-CREATION > /trunk/content/samplecontainer/examples/oauth2/shindig_authorization.xml > PRE-CREATION > > /trunk/content/samplecontainer/examples/oauth2/shindig_client_credentials.xml > PRE-CREATION > /trunk/features/src/main/javascript/features/core.io/io.js 1182008 > > /trunk/features/src/main/javascript/features/shindig.xhrwrapper/xhrwrapper.js > 1182008 > /trunk/java/common/conf/shindig.properties 1182008 > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AuthType.java > 1182008 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/config/XhrwrapperConfigContributor.java > 1182008 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java > 1182008 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultInvalidationService.java > 1182008 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultRequestPipeline.java > 1182008 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java > 1182008 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/GadgetOAuthTokenStore.java > 1182008 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Accessor.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Message.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Request.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/GadgetOAuth2TokenStore.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Accessor.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Arguments.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Error.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2FetcherConfig.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2GadgetContext.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Message.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2MessageModule.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Module.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Request.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2RequestException.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2ResponseParams.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Store.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Token.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Utils.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/AuthorizationEndpointResponseHandler.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/BasicAuthenticationHandler.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/BearerTokenHandler.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/ClientAuthenticationHandler.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/ClientCredentialsGrantTypeHandler.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/CodeAuthorizationResponseHandler.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/CodeGrantTypeHandler.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/GrantRequestHandler.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/MacTokenHandler.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/OAuth2HandlerError.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/OAuth2HandlerModule.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/ResourceRequestHandler.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/StandardAuthenticationHandler.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/TokenAuthorizationResponseHandler.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/TokenEndpointResponseHandler.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/logger/FilteredLogger.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Cache.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2CacheException.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Encrypter.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2EncryptionException.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2PersistenceException.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Persister.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2TokenPersistence.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/InMemoryCache.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/NoOpEncrypter.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/OAuth2GadgetBinding.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/OAuth2PersistenceModule.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/OAuth2Provider.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/preload/HttpPreloader.java > 1182008 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/ProxyRenderer.java > 1182008 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HttpRequestHandler.java > 1182008 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java > 1182008 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/OAuth2CallbackServlet.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/BaseOAuthService.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/ModulePrefs.java > 1182008 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/OAuth2Service.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/OAuth2Spec.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/OAuthService.java > 1182008 > > /trunk/java/gadgets/src/main/resources/org/apache/shindig/gadgets/oauth2/resource.properties > PRE-CREATION > > /trunk/java/gadgets/src/main/resources/org/apache/shindig/gadgets/oauth2/resource_en_US.properties > PRE-CREATION > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/AuthTypeTest.java > 1182008 > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/DefaultInvalidationServiceTest.java > 1182008 > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/DefaultRequestPipelineTest.java > 1182008 > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/GadgetOAuth2TokenStoreTest.java > PRE-CREATION > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/MockUtils.java > PRE-CREATION > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/OAuth2ArgumentsTest.java > PRE-CREATION > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/OAuth2ErrorTest.java > PRE-CREATION > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/OAuth2FetcherConfigTest.java > PRE-CREATION > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/OAuth2GadgetContextTest.java > PRE-CREATION > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/OAuth2MessageModuleTest.java > PRE-CREATION > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/OAuth2ModuleTest.java > PRE-CREATION > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/OAuth2RequestExceptionTest.java > PRE-CREATION > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/OAuth2ResponseParamsTest.java > PRE-CREATION > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/handler/BasicAuthenticationHandlerTest.java > PRE-CREATION > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/handler/BearerTokenHandlerTest.java > PRE-CREATION > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/handler/ClientCredentialsGrantTypeHandlerTest.java > PRE-CREATION > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/handler/CodeAuthorizationResponseHandlerTest.java > PRE-CREATION > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/handler/CodeGrantTypeHandlerTest.java > PRE-CREATION > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/handler/MacTokenHandlerTest.java > PRE-CREATION > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/handler/OAuth2HandlerErrorTest.java > PRE-CREATION > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/handler/OAuth2HandlerModuleTest.java > PRE-CREATION > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/handler/StandardAuthenticationHandlerTest.java > PRE-CREATION > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/handler/TokenAuthorizationResponseHandlerTest.java > PRE-CREATION > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/logger/FilteredLoggerTest.java > PRE-CREATION > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2CacheExceptionTest.java > PRE-CREATION > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2ClientTest.java > PRE-CREATION > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2EncryptionExceptionTest.java > PRE-CREATION > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2PersistenceExceptionTest.java > PRE-CREATION > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2TokenPersistenceTest.java > PRE-CREATION > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/sample/InMemoryCacheTest.java > PRE-CREATION > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2PersisterTest.java > PRE-CREATION > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/sample/NoOpEncrypterTest.java > PRE-CREATION > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/sample/OAuth2GadgetBindingTest.java > PRE-CREATION > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/sample/OAuth2PersistenceModuleTest.java > PRE-CREATION > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/sample/OAuth2ProviderTest.java > PRE-CREATION > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/RewriteModuleTest.java > 1182008 > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/StyleTagProxyEmbeddedUrlsVisitorTest.java > 1182008 > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/tags/TemplateBasedTagHandlerTest.java > 1182008 > > /trunk/java/gadgets/src/test/resources/org/apache/shindig/gadgets/oauth2/oauth2_test.json > PRE-CREATION > /trunk/java/server/pom.xml 1182008 > /trunk/java/server/src/main/webapp/WEB-INF/web.xml 1182008 > > /trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndServer.java > 1182008 > > Diff: https://reviews.apache.org/r/1947/diff > > > Testing > ------- > > Yes, passed all JUnit tests with mantis build. tested with new OAuth2 demo > pages. > > > Thanks, > > li > >
