----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3165/#review4011 -----------------------------------------------------------
Matt there is some good cleanup here, thanks! I am just wondering whether it makes sense to have this functionality added to the embedded experience sample container that is already part of Shindig? What do you think.... /trunk/content/samplecontainer/examples/commoncontainer/viewController.js <https://reviews.apache.org/r/3165/#comment9083> Looks like there is some spacing problems here /trunk/content/samplecontainer/examples/commoncontainer/viewController.js <https://reviews.apache.org/r/3165/#comment9084> I believe jQuery provides a function that we can use instead of eval /trunk/content/samplecontainer/examples/commoncontainer/viewController.js <https://reviews.apache.org/r/3165/#comment9085> It might be worth also specifying height and width for URL Rendar Params - Ryan On 2011-12-13 16:04:45, Matt Marum wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3165/ > ----------------------------------------------------------- > > (Updated 2011-12-13 16:04:45) > > > Review request for shindig. > > > Summary > ------- > > As we start to build (and promote the use of) embedded experience gadgets, we > need to provide easier ways for Gadget developers to quickly prototype these > gadgets. I'd like to add an Embedded Experience Gadgets section to the Common > Container test environment > (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can > quickly set a Gadget URL and the context to be passed on render. > > This has makes quickly testing EE gadgets much easier. > > > This addresses bug SHINDIG-1675. > https://issues.apache.org/jira/browse/SHINDIG-1675 > > > Diffs > ----- > > /trunk/content/samplecontainer/examples/commoncontainer/assembler.js > 1213743 > /trunk/content/samplecontainer/examples/commoncontainer/cconviews.js > 1213743 > /trunk/content/samplecontainer/examples/commoncontainer/index.html 1213743 > /trunk/content/samplecontainer/examples/commoncontainer/viewController.js > 1213743 > > Diff: https://reviews.apache.org/r/3165/diff > > > Testing > ------- > > Tested locally with some EE gadgets I've been building. Andy Smith has used > it too. There are no automated tests for the sample containers. > > > Thanks, > > Matt > >
