----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3165/#review4265 -----------------------------------------------------------
Ship it! Removed extra white space and committed. Thanks Matt! Committed revision 1229170. - Ryan On 2012-01-08 23:08:29, Matt Marum wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3165/ > ----------------------------------------------------------- > > (Updated 2012-01-08 23:08:29) > > > Review request for shindig. > > > Summary > ------- > > As we start to build (and promote the use of) embedded experience gadgets, we > need to provide easier ways for Gadget developers to quickly prototype these > gadgets. I'd like to add an Embedded Experience Gadgets section to the Common > Container test environment > (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can > quickly set a Gadget URL and the context to be passed on render. > > This has makes quickly testing EE gadgets much easier. > > > This addresses bug SHINDIG-1675. > https://issues.apache.org/jira/browse/SHINDIG-1675 > > > Diffs > ----- > > /trunk/content/samplecontainer/examples/commoncontainer/assembler.js > 1228330 > /trunk/content/samplecontainer/examples/commoncontainer/cconviews.js > 1228330 > /trunk/content/samplecontainer/examples/commoncontainer/index.html 1228330 > /trunk/content/samplecontainer/examples/commoncontainer/viewController.js > 1228330 > > Diff: https://reviews.apache.org/r/3165/diff > > > Testing > ------- > > Tested locally with some EE gadgets I've been building. Andy Smith has used > it too. There are no automated tests for the sample containers. > > > Thanks, > > Matt > >
