-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3938/#review5172
-----------------------------------------------------------
I think this would make more sense to add to the existing gadget-admin.json
file instead of into the container.js config. It would keep all of the "admin"
stuff in one place.
So today we have something like this in gadget-admin.json:
{
"default" : {
"gadgets" : {
"http://www.google.com/ig/modules/horoscope.xml"; : {
"features" : ["views", "tabs", "setprefs", "dynamic-height"],
"type" : "blacklist"
}
}
}
}
You could just add another attribute that is a sibling to "gadgets" (name
pending)
{
"default" : {
"gadgets" : {
"http://www.google.com/ig/modules/horoscope.xml"; : {
"features" : ["views", "tabs", "setprefs", "dynamic-height"],
"type" : "blacklist"
}
},
"additional_rpc_endpoints" : ["foobar"]
}
}
You could read the new array on the server-side when processing the list of
allowed endpoints from the feature.xmls before shipping that info off to the
container.
- Stanton
On 2012-02-16 21:57:16, Ryan Baxter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3938/
> -----------------------------------------------------------
>
> (Updated 2012-02-16 21:57:16)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> If you enable RPC arbitration in a container and you want to allow a set of
> RPC service ids regardless of whether the gadgets has features that uses
> them, it is very difficult to do so. The only way to do this today is to
> provide your own arbitrator function to the common container. Essentially
> this function will do the same thing as the default implementation in the
> common container except have a list of allowed RPC service ids. It would be
> much easier for consumers of the common container to supply a list of allowed
> RPC service ids for this container in the config.
>
>
> This addresses bug SHINDIG-1709.
> https://issues.apache.org/jira/browse/SHINDIG-1709
>
>
> Diffs
> -----
>
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js
> 1245178
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
> 1245178
>
> Diff: https://reviews.apache.org/r/3938/diff
>
>
> Testing
> -------
>
> Tested in common container
>
>
> Thanks,
>
> Ryan
>
>
