----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3938/ -----------------------------------------------------------
(Updated 2012-02-20 21:48:36.261908)
Review request for shindig.
Changes
-------
Updated implementation based on gadget admin features.
Summary (updated)
-------
If you enable RPC arbitration in a container and you want to allow a set of RPC
service ids regardless of whether the gadgets has features that uses them, it
is very difficult to do so. The only way to do this today is to provide your
own arbitrator function to the common container. Essentially this function will
do the same thing as the default implementation in the common container except
have a list of allowed RPC service ids. It be easier if containers could
specify a list of additional RPC services to allow on a per gadget basis. It
would also be nice if this was integrated into the gadget admin feature in
Shindig already.
This addresses bug SHINDIG-1709.
https://issues.apache.org/jira/browse/SHINDIG-1709
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/config/gadget-admin.json
1245178
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
1245178
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/BasicGadgetAdminStore.java
1245178
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/GadgetAdminData.java
1245178
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/GadgetAdminStore.java
1245178
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/RpcAdminData.java
PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java
1245178
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/BasicGadgetAdminStoreTest.java
1245178
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/ContainerAdminDataTest.java
1245178
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/GadgetAdminDataTest.java
1245178
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/RpcAdminDataTest.java
PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/ServerAdminDataTest.java
1245178
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java
1245178
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java
1245178
Diff: https://reviews.apache.org/r/3938/diff
Testing (updated)
-------
Updated and added unit tests. Also tested in common container.
Thanks,
Ryan
