----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4626/ -----------------------------------------------------------
Review request for shindig and Dan Dumont. Summary ------- >From the discussion in OpenSocial list and Google group: >https://groups.google.com/forum/?fromgroups#!topic/opensocial-and-gadgets-spec/qX45Po_Dqfo > we are missing the <actions> tag to wrap <action> tag for the >actions-contributions feature param. To make sure Shindig follow OpenSocial specs and to follow the spirit of Shindig to be following closer the OpenSocial specs, we need to change the sample gadget and code handler to follow OpenSocial 2.0 spec. So instead of : <Require feature="actions"> <Param name="action-contributions"><![CDATA[ <actions> <action id="org-samplevoip-chatwithperson" dataType="opensocial.Person" label="Chat" tooltip="Chat" /> <action id="org-samplevoip-callbyperson" dataType="opensocial.Person" label="Call" tooltip="Call" /> <action id="org-samplevoip-globalcall" path="container/navigationLinks" label="VOIP Call" tooltip="Call using VOIP" /> </actions> ]]></Param> </Require> it will be: <Require feature="actions"> <Param name="action-contributions"><![CDATA[ <action id="org-samplevoip-chatwithperson" dataType="opensocial.Person" label="Chat" tooltip="Chat" /> <action id="org-samplevoip-callbyperson" dataType="opensocial.Person" label="Call" tooltip="Call" /> <action id="org-samplevoip-globalcall" path="container/navigationLinks" label="VOIP Call" tooltip="Call using VOIP" /> ]]></Param> </Require> Also change from text/xml to application/xml since text/xml seems to be deprecated (http://tools.ietf.org/html/draft-murata-kohn-lilley-xml-03) Diffs ----- trunk/content/samplecontainer/examples/conservcontainer/sample-actions-voip.xml 1309085 trunk/features/src/main/javascript/features/actions/actions_container.js 1309085 Diff: https://reviews.apache.org/r/4626/diff Testing ------- Run the sample app in common container Thanks, Henry
