----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4626/#review6679 -----------------------------------------------------------
trunk/features/src/main/javascript/features/actions/actions_container.js <https://reviews.apache.org/r/4626/#comment14476> This impl will easily break when/if we extend the actions tag to have attributes. I think that I might prefer that we parse this dom structure and insert the actions element after, either in the dom before we jsonify it, or in the json after it's been converted to json. It looks like if you do the latter, the change is quite simple. - Dan On 2012-04-03 19:01:06, Henry Saputra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4626/ > ----------------------------------------------------------- > > (Updated 2012-04-03 19:01:06) > > > Review request for shindig and Dan Dumont. > > > Summary > ------- > > From the discussion in OpenSocial list and Google group: > https://groups.google.com/forum/?fromgroups#!topic/opensocial-and-gadgets-spec/qX45Po_Dqfo > we are missing the <actions> tag to wrap <action> tag for the > actions-contributions feature param. > > To make sure Shindig follow OpenSocial specs and to follow the spirit of > Shindig to be following closer the OpenSocial specs, we need to change the > sample gadget and code handler to follow OpenSocial 2.0 spec. > > So instead of : > > <Require feature="actions"> > <Param name="action-contributions"><![CDATA[ > <actions> > <action id="org-samplevoip-chatwithperson" > dataType="opensocial.Person" label="Chat" tooltip="Chat" /> > <action id="org-samplevoip-callbyperson" > dataType="opensocial.Person" label="Call" tooltip="Call" /> > <action id="org-samplevoip-globalcall" > path="container/navigationLinks" label="VOIP Call" tooltip="Call using VOIP" > /> > </actions> > ]]></Param> > </Require> > > it will be: > > <Require feature="actions"> > <Param name="action-contributions"><![CDATA[ > <action id="org-samplevoip-chatwithperson" > dataType="opensocial.Person" label="Chat" tooltip="Chat" /> > <action id="org-samplevoip-callbyperson" dataType="opensocial.Person" > label="Call" tooltip="Call" /> > <action id="org-samplevoip-globalcall" > path="container/navigationLinks" label="VOIP Call" tooltip="Call using VOIP" > /> > ]]></Param> > </Require> > > Also change from text/xml to application/xml since text/xml seems to be > deprecated (http://tools.ietf.org/html/draft-murata-kohn-lilley-xml-03) > > > Diffs > ----- > > > trunk/content/samplecontainer/examples/conservcontainer/sample-actions-voip.xml > 1309085 > trunk/features/src/main/javascript/features/actions/actions_container.js > 1309085 > > Diff: https://reviews.apache.org/r/4626/diff > > > Testing > ------- > > Run the sample app in common container > > > Thanks, > > Henry > >
