----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4896/#review7281 -----------------------------------------------------------
LGTM. Since our existing test cases didn't catch this can we add a test case for this? - Ryan On 2012-04-26 20:13:12, Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4896/ > ----------------------------------------------------------- > > (Updated 2012-04-26 20:13:12) > > > Review request for shindig. > > > Summary > ------- > > Ran into an issue where the server response was being partially un-escaped by > the browser if it had escaped html entities in it. > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java > 1329959 > > Diff: https://reviews.apache.org/r/4896/diff > > > Testing > ------- > > Tests still pass :) > > > Thanks, > > Dan > >
