> On 2012-04-26 21:15:47, Ryan Baxter wrote: > > LGTM. Since our existing test cases didn't catch this can we add a test > > case for this? > > Dan Dumont wrote: > A jsunit test case wouldn't have caught this I don't think... It would > require a functional dom and iframe component to see the issue.
But you could write a junit test and verify we escape it properly so when it does get returned to the browser we don't run into the problem. - Ryan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4896/#review7281 ----------------------------------------------------------- On 2012-04-27 13:24:54, Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4896/ > ----------------------------------------------------------- > > (Updated 2012-04-27 13:24:54) > > > Review request for shindig. > > > Summary > ------- > > Ran into an issue where the server response was being partially un-escaped by > the browser if it had escaped html entities in it. > > > This addresses bug SHINDIG-1761. > https://issues.apache.org/jira/browse/SHINDIG-1761 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java > 1329959 > > Diff: https://reviews.apache.org/r/4896/diff > > > Testing > ------- > > Tests still pass :) > > > Thanks, > > Dan > >
