http://codereview.appspot.com/6305079/diff/1002/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/GroupId.java File java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/GroupId.java (right):
http://codereview.appspot.com/6305079/diff/1002/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/GroupId.java#newcode115 java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/GroupId.java:115: String type = parseType(objectId); I wonder if parseType could be smart enough to recognize a custom groupId that starts with @ but isn't one of the spec defined ones? Then you could just do else if (type.equals("custom")) return Type.custom; http://codereview.appspot.com/6305079/diff/1002/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/GroupId.java#newcode122 java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/GroupId.java:122: } else if(objectId instanceof String && ((String)objectId).startsWith("@")) { Would a Type.unknown or Type.custom be better than a null? http://codereview.appspot.com/6305079/
