> On June 27, 2012, 9:55 p.m., Ryan Baxter wrote: > > /trunk/content/samplecontainer/examples/templates/TemplateClientAPI.xml, > > line 7 > > <https://reviews.apache.org/r/5600/diff/1/?file=116678#file116678line7> > > > > Where is this library?
That file is already in the folder with this gadget. It is a template library used from another sample gadget that I was reusing so that I didn't have to duplicate all the code. > On June 27, 2012, 9:55 p.m., Ryan Baxter wrote: > > /trunk/features/src/main/javascript/features/opensocial-templates/template.js, > > line 95 > > <https://reviews.apache.org/r/5600/diff/1/?file=116680#file116680line95> > > > > When reading the code, if a param is optional it is good to denote that > > in the parameter name, such as opt_tag. Also I guess you can use the JS > > doc annotation suggested here > > http://code.google.com/p/jsdoc-toolkit/wiki/TagParam I had the parameter in the JS docs as "tag (optional)". I went ahead and changed the param name to opt_tag and changes the JS docs to "[opt_tag]" as per the recommendation. - Chris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5600/#review8670 ----------------------------------------------------------- On June 26, 2012, 11:21 p.m., Chris Geer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5600/ > ----------------------------------------------------------- > > (Updated June 26, 2012, 11:21 p.m.) > > > Review request for shindig. > > > Description > ------- > > OS Templates that were defined in template libraries were not available from > the client APIs because registration was failing. This patch registers them > so they can be used. > > One side effect is that due to some timing with onLoadHandlers and templates, > if template libraries are used, templates defined in the module statically > are no longer available to the client apis. This patch will allow you to use > one or the other from the client libraries but not both. > > > This addresses bug SHINDIG-1788. > https://issues.apache.org/jira/browse/SHINDIG-1788 > > > Diffs > ----- > > /trunk/content/samplecontainer/examples/templates/TemplateClientAPI.xml > PRE-CREATION > /trunk/features/src/main/javascript/features/opensocial-templates/loader.js > 1354233 > > /trunk/features/src/main/javascript/features/opensocial-templates/template.js > 1354233 > > Diff: https://reviews.apache.org/r/5600/diff/ > > > Testing > ------- > > Created an example gadget and tested it in the samplecontainer runtime. > > > Thanks, > > Chris Geer > >
