----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5600/ -----------------------------------------------------------
(Updated June 29, 2012, 3:42 a.m.) Review request for shindig. Changes ------- Reverted change to registerTemplate and just set the id of the template to the tag through the compile xml node method that already existed. Description ------- OS Templates that were defined in template libraries were not available from the client APIs because registration was failing. This patch registers them so they can be used. One side effect is that due to some timing with onLoadHandlers and templates, if template libraries are used, templates defined in the module statically are no longer available to the client apis. This patch will allow you to use one or the other from the client libraries but not both. This addresses bug SHINDIG-1788. https://issues.apache.org/jira/browse/SHINDIG-1788 Diffs (updated) ----- /trunk/content/samplecontainer/examples/templates/TemplateClientAPI.xml PRE-CREATION /trunk/features/src/main/javascript/features/opensocial-templates/loader.js 1354233 Diff: https://reviews.apache.org/r/5600/diff/ Testing ------- Created an example gadget and tested it in the samplecontainer runtime. Thanks, Chris Geer