> On Aug. 4, 2012, 6:52 p.m., Ryan Baxter wrote: > > After applying the patch SVN doesn't appear to think there actually any > > changes in the file, what tool did you use to do the conversion? Maybe one > > of the committers can just run it and check in the changes. > > Marshall Shi wrote: > Yeah, probably just some end of line or end of file format change. I used > a tool named "dos2unix-6.0-win32" to convert the file.
Committed revision 1371317 - Ryan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6205/#review9849 ----------------------------------------------------------- On July 30, 2012, 8:51 a.m., Marshall Shi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6205/ > ----------------------------------------------------------- > > (Updated July 30, 2012, 8:51 a.m.) > > > Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers. > > > Description > ------- > > In our Shindig extensions, we applied a few patches to gadget_holder.js, > however, we found the file format will break the patch process. We fixed this > problem by updating the gadget_holder.js, using a dos to unix file convert > tool. > > Note: the file content is not changed. > > > This addresses bug shindig-1833. > https://issues.apache.org/jira/browse/shindig-1833 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js > 1351249 > > Diff: https://reviews.apache.org/r/6205/diff/ > > > Testing > ------- > > > Thanks, > > Marshall Shi > >
