----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6606/#review10302 -----------------------------------------------------------
Ship it! Thanks for the tests! - Ryan Baxter On Aug. 14, 2012, 7:13 p.m., Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6606/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2012, 7:13 p.m.) > > > Review request for shindig and Henry Saputra. > > > Description > ------- > > Container should not call showAction API for actions with an invalid type. > > > This addresses bug SHINDIG-1854. > https://issues.apache.org/jira/browse/SHINDIG-1854 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js > 1372888 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js > 1372888 > > Diff: https://reviews.apache.org/r/6606/diff/ > > > Testing > ------- > > Added test for showactions with invalid object. > > Added mechanism to mock rpc endpoints and use the associated callbacks (we > should make more broad use of this in our feature code). > > > Thanks, > > Dan Dumont > >
