> On Aug. 6, 2012, 6:39 p.m., Dan Dumont wrote:
> > It looks like we could just augment the method
> > org.apache.shindig.common.servlet.HttpUtil.getCachingHeadersToSet(int,
> > boolean) to do:
> > cachingHeaders.add(Pair.of("Pragma", "no-cache"));
> > cachingHeaders.add(Pair.of("Cache-Control", "no-store, no-cache"));
> >
> > and revert all of your other changes.
> >
> > Would this solve the problem you're talking about?
>
> Dan Dumont wrote:
> In other words, I'm not sure that we need to keep the upstream
> cache-control headers.
>
> IE seems to have issues (surprise!) with only no-cache. Most of the
> literature on the subject suggests using both no-store and no-cache always if
> you don't want something to be cached at all.
> The Pragma may be blank on the original response, but the specs say it's
> for HTTP 1.0 compat so I think we should keep that.
The HttpUtil methods seem missing the fetched result from content server as
param. They are used to manipulate the response directly.
If we need to pass in the cache control info from the fetched result, a few
refactoring to the util methods...
- Marshall
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6201/#review9893
-----------------------------------------------------------
On Sept. 11, 2012, 2:55 a.m., Marshall Shi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6201/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2012, 2:55 a.m.)
>
>
> Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and
> Rich Thompson.
>
>
> Description
> -------
>
> Http response header has been modified when the refresh is set to -1.
> However, in IE8, it needs the original response header been passed through
> proxy.
> Shindig is using cache-control: no-cache and Progma: no-cache header if TTL
> is less than or equals to zero. It is not working for IE. IE would expect the
> Cache-Control: no-store and progama: "" which are returned from original
> content server response. The current shindig code already rewrite the header
> a bit in this case, so the proposed fix is to leverage the original header
> for cache control and progma.
>
>
> This addresses bug shindig-1831.
> https://issues.apache.org/jira/browse/shindig-1831
>
>
> Diffs
> -----
>
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/HttpUtil.java
> 1373213
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ServletUtil.java
> 1373213
>
> Diff: https://reviews.apache.org/r/6201/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marshall Shi
>
>
