----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6201/#review11344 -----------------------------------------------------------
Ship it! +1 - Henry Saputra On Sept. 11, 2012, 2:55 a.m., Marshall Shi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6201/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2012, 2:55 a.m.) > > > Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and > Rich Thompson. > > > Description > ------- > > Http response header has been modified when the refresh is set to -1. > However, in IE8, it needs the original response header been passed through > proxy. > Shindig is using cache-control: no-cache and Progma: no-cache header if TTL > is less than or equals to zero. It is not working for IE. IE would expect the > Cache-Control: no-store and progama: "" which are returned from original > content server response. The current shindig code already rewrite the header > a bit in this case, so the proposed fix is to leverage the original header > for cache control and progma. > > > This addresses bug shindig-1831. > https://issues.apache.org/jira/browse/shindig-1831 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/HttpUtil.java > 1373213 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ServletUtil.java > 1373213 > > Diff: https://reviews.apache.org/r/6201/diff/ > > > Testing > ------- > > > Thanks, > > Marshall Shi > >
