----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9177/#review15935 -----------------------------------------------------------
Could you please create some unit tests so that we can verify this behavior as we continue to evolve shindig? /trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/PersonHandler.java <https://reviews.apache.org/r/9177/#comment34227> Could you please process all changed and new files by removing all line ending whitespaces? usually a regex replace of [ \t]+$ with {empty string} will do it. /trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/PersonHandler.java <https://reviews.apache.org/r/9177/#comment34230> This error message (and the one below) is a bit misleading. The groupId may be another specified value that we do not support yet, and it wouldn't necessarily mean creating or deleting the person. Could you put in separate checks for both with appropriate messages? /trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/FriendService.java <https://reviews.apache.org/r/9177/#comment34231> Please provide a default implementation for this interface. - Dan Dumont On Jan. 31, 2013, 12:57 p.m., René Peinl wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9177/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2013, 12:57 p.m.) > > > Review request for shindig. > > > Description > ------- > > see https://issues.apache.org/jira/browse/SHINDIG-1899 > > > Diffs > ----- > > > /trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/PersonHandler.java > 1437957 > > /trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/FriendService.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/9177/diff/ > > > Testing > ------- > > > Thanks, > > René Peinl > >
