----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9177/#review16856 -----------------------------------------------------------
Ship it! Looks good to me, thanks for working on this! - Dan Dumont On Feb. 12, 2013, 8:49 a.m., René Peinl wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9177/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2013, 8:49 a.m.) > > > Review request for shindig. > > > Description > ------- > > see https://issues.apache.org/jira/browse/SHINDIG-1899 > > > This addresses bug SHINDIG-1899. > https://issues.apache.org/jira/browse/SHINDIG-1899 > > > Diffs > ----- > > > /trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/spi/JPASocialModule.java > 1437957 > /trunk/java/social-api/pom.xml 1437957 > > /trunk/java/social-api/src/main/java/org/apache/shindig/social/core/spi/FriendServiceImpl.java > PRE-CREATION > > /trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/PersonHandler.java > 1437957 > > /trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/FriendService.java > PRE-CREATION > > /trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/SampleModule.java > 1437957 > > /trunk/java/social-api/src/test/java/org/apache/shindig/social/SocialApiTestsGuiceModule.java > 1437957 > > /trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java > 1437957 > > Diff: https://reviews.apache.org/r/9177/diff/ > > > Testing > ------- > > > Thanks, > > René Peinl > >