Just from the peanut gallery, but neo4j is AGPL licensed.
Normally any database backend access which is abstracted away behind 'plain'
JDBC interfaces are allright to use, commercial versions or otherwise licensed,
because the end-user would have the option to choose whatever (compatible)
database they want to use.
However with neo4j this seems different. Even with only optional support for
neo4j, the neo4j integration might require explicit neo4j (Java) APIs and
dependencies? I haven't reviewed the code for this, but if it imports neo4j APIs
then their AGPL license can be too invasive and then possibly not acceptable for
uses within our AL2.0 licensed codebase.
Or even if that could be allowed, I would make sure to check and ask
(legal-discuss@ etc.) if it would be acceptable from ASF policy POV.
Regards, Ate
On 03/07/2013 07:46 PM, Henry Saputra wrote:
This is good news.
One immediate comment is about the package name.
Would it be possible to put it under org.apache.shindig rather than the
de.hofuniversity?
This would make the contributions uniform like from other companies and
organizations.
- Henry
2013/3/6 René Peinl <rene.pe...@hof-university.de>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9773/
-----------------------------------------------------------
Review request for shindig.
Description
-------
Review for Shindig-1911
Alternative database backend based on graph database neo4j
Any comments welcome. We are committed to further improve this.
This addresses bug Shindig-1911.
https://issues.apache.org/jira/browse/Shindig-1911
Diffs
-----
/trunk/java/neo4j-backend/pom.xml PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/Constants.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/GraphAPIModule.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/GraphConfig.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/GuiceModule.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/INeo4jConnector.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/Neo4jConnector.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/Neo4jHAConnector.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/Neo4jRelTypes.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/Neo4jRestConnector.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/ExtOrgPersonImpl.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/ExtOrganizationImpl.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/IExtOrgPerson.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/IExtOrganization.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherActivityEntry.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherActivityObject.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherAttributesMessage.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherListFieldList.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherMessage.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherMessageCollection.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherPerson.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/ADataTransferObject.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/AccountDTO.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/ActivityDTO.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/ActivityEntryDTO.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/ActivityObjectDTO.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/AddressDTO.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/DTOHelper.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/GroupDTO.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/MediaItemDTO.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/MediaLinkDTO.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/MessageCollectionDTO.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/MessageDTO.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/OrganizationDTO.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/PersonDTO.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphAccount.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphActivity.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphActivityEntry.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphActivityObject.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphAddress.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphAppData.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphGroup.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphListFieldList.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMediaItem.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMediaLink.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMessage.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMessageCollection.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphOrganization.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphPerson.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringAccount.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringAddress.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringApplication.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringOrganization.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringPerson.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/service/ExtPersonHandler.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/service/UserHandler.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphActivitySPI.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphActivityStreamSPI.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphAlbumSPI.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphAppDataSPI.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphFriendSPI.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphGroupSPI.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphMediaItemSPI.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphMessageSPI.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphPersonSPI.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphSPI.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/IExtPersonService.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/IFriendService.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/IGraphService.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherActivityStreamSPI.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherGraphSPI.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherGroupSPI.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherMessageSPI.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherPersonSPI.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherActivityStreamSPI.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherGraphSPI.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherGroupSPI.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherMessageSPI.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherPersonSPI.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/dsl/RestCypherDSLPersonSPI.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/gremlin/GremlinGraphSPI.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/gremlin/GremlinMessageSPI.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/gremlin/GremlinPersonSPI.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/spring/PersonRepository.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/spring/SpringPersonSPI.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/service/ActivityObjectService.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/service/ApplicationService.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/service/IDManager.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/testdata/BatchParser.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/testdata/DataGenerator.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/testdata/DataParser.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/util/NodeFilter.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/util/NodeSorter.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/util/PersonFilter.java
PRE-CREATION
/trunk/java/neo4j-backend/src/main/resources/graph-backend.properties
PRE-CREATION
/trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphActivityEntryTest.java
PRE-CREATION
/trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphAppDataTest.java
PRE-CREATION
/trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphGroupTest.java
PRE-CREATION
/trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMessageCollectionTest.java
PRE-CREATION
/trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMessageTest.java
PRE-CREATION
/trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphPersonTest.java
PRE-CREATION
/trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/service/UserHandlerTest.java
PRE-CREATION
/trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphActivitySPITest.java
PRE-CREATION
/trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphActivityStreamSPITest.java
PRE-CREATION
/trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphAppDataSPITest.java
PRE-CREATION
/trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphFriendSPITest.java
PRE-CREATION
/trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphGroupSPITest.java
PRE-CREATION
/trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphMessageSPITest.java
PRE-CREATION
/trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphPersonSPITest.java
PRE-CREATION
/trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphSPITest.java
PRE-CREATION
/trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/service/ActivityObjectServiceTest.java
PRE-CREATION
/trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/service/ApplicationServiceTest.java
PRE-CREATION
/trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/service/IDManagerTest.java
PRE-CREATION
/trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/util/NodeFilterTest.java
PRE-CREATION
/trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/util/NodeSorterTest.java
PRE-CREATION
/trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/util/PersonFilterTest.java
PRE-CREATION
/trunk/pom.xml 1452786
Diff: https://reviews.apache.org/r/9773/diff/
Testing
-------
Thanks,
René Peinl
