Dear Ate, thanks for your comments. I already thought about this and asked the guys from neo technologies. Here is the answer from Peter Neubauer.
in principle (IANAL) it is ok to have ALv2 licensed code binding to GPL code. In runtime, the user will not be shielded from the GPL core, which means the runtime will have GPL characteristics when you plug in Neo4j. That is exactly the intent, and should be ok. The bindings-code is development-time Apache license, regarding contributions and copyright etc, so I think this should be ok. I'm not quite sure if that answers your question. I can further investigate if necessary. Regards René -----Ursprüngliche Nachricht----- Von: Ate Douma [mailto:a...@douma.nu] Gesendet: Freitag, 8. März 2013 14:18 An: dev@shindig.apache.org Betreff: Re: Review Request: Alternative database backend based on graph database neo4j Just from the peanut gallery, but neo4j is AGPL licensed. Normally any database backend access which is abstracted away behind 'plain' JDBC interfaces are allright to use, commercial versions or otherwise licensed, because the end-user would have the option to choose whatever (compatible) database they want to use. However with neo4j this seems different. Even with only optional support for neo4j, the neo4j integration might require explicit neo4j (Java) APIs and dependencies? I haven't reviewed the code for this, but if it imports neo4j APIs then their AGPL license can be too invasive and then possibly not acceptable for uses within our AL2.0 licensed codebase. Or even if that could be allowed, I would make sure to check and ask (legal-discuss@ etc.) if it would be acceptable from ASF policy POV. Regards, Ate On 03/07/2013 07:46 PM, Henry Saputra wrote: > This is good news. > > One immediate comment is about the package name. > Would it be possible to put it under org.apache.shindig rather than > the de.hofuniversity? > > This would make the contributions uniform like from other companies > and organizations. > > - Henry > > > 2013/3/6 René Peinl <rene.pe...@hof-university.de> > >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/9773/ >> ----------------------------------------------------------- >> >> Review request for shindig. >> >> >> Description >> ------- >> >> Review for Shindig-1911 >> Alternative database backend based on graph database neo4j Any >> comments welcome. We are committed to further improve this. >> >> >> This addresses bug Shindig-1911. >> https://issues.apache.org/jira/browse/Shindig-1911 >> >> >> Diffs >> ----- >> >> /trunk/java/neo4j-backend/pom.xml PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/Constants.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/GraphAPIModule.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/GraphConfig.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/GuiceModule.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/db/neo4j/INeo4jConnector.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/db/neo4j/Neo4jConnector.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/db/neo4j/Neo4jHAConnector.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/db/neo4j/Neo4jRelTypes.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/db/neo4j/Neo4jRestConnector.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/ExtOrgPersonImpl.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/ExtOrganizationImpl.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/IExtOrgPerson.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/IExtOrganization.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/cypher/CypherActivityEntry.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/cypher/CypherActivityObject.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/cypher/CypherAttributesMessage.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/cypher/CypherListFieldList.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/cypher/CypherMessage.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/cypher/CypherMessageCollection.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/cypher/CypherPerson.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/dto/ADataTransferObject.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/dto/AccountDTO.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/dto/ActivityDTO.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/dto/ActivityEntryDTO.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/dto/ActivityObjectDTO.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/dto/AddressDTO.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/dto/DTOHelper.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/dto/GroupDTO.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/dto/MediaItemDTO.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/dto/MediaLinkDTO.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/dto/MessageCollectionDTO.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/dto/MessageDTO.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/dto/OrganizationDTO.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/dto/PersonDTO.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/graph/GraphAccount.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/graph/GraphActivity.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/graph/GraphActivityEntry.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/graph/GraphActivityObject.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/graph/GraphAddress.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/graph/GraphAppData.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/graph/GraphGroup.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/graph/GraphListFieldList.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/graph/GraphMediaItem.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/graph/GraphMediaLink.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/graph/GraphMessage.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/graph/GraphMessageCollection.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/graph/GraphOrganization.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/graph/GraphPerson.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/spring/SpringAccount.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/spring/SpringAddress.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/spring/SpringApplication.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/spring/SpringOrganization.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/model/spring/SpringPerson.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/service/ExtPersonHandler.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/service/UserHandler.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/GraphActivitySPI.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/GraphActivityStreamSPI.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/GraphAlbumSPI.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/GraphAppDataSPI.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/GraphFriendSPI.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/GraphGroupSPI.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/GraphMediaItemSPI.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/GraphMessageSPI.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/GraphPersonSPI.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/GraphSPI.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/IExtPersonService.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/IFriendService.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/IGraphService.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/cypher/CypherActivityStreamSPI.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/cypher/CypherGraphSPI.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/cypher/CypherGroupSPI.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/cypher/CypherMessageSPI.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/cypher/CypherPersonSPI.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/cypher/RestCypherActivityStreamSPI.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/cypher/RestCypherGraphSPI.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/cypher/RestCypherGroupSPI.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/cypher/RestCypherMessageSPI.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/cypher/RestCypherPersonSPI.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/cypher/dsl/RestCypherDSLPersonSPI.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/gremlin/GremlinGraphSPI.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/gremlin/GremlinMessageSPI.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/gremlin/GremlinPersonSPI.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/spring/PersonRepository.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/spring/SpringPersonSPI.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/service/ActivityObjectService.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/service/ApplicationService.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/service/IDManager.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/testdata/BatchParser.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/testdata/DataGenerator.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/testdata/DataParser.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/util/NodeFilter.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/util/NodeSorter.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb >> ackend/util/PersonFilter.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/main/resources/graph-backend.properties >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb >> ackend/model/graph/GraphActivityEntryTest.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb >> ackend/model/graph/GraphAppDataTest.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb >> ackend/model/graph/GraphGroupTest.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb >> ackend/model/graph/GraphMessageCollectionTest.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb >> ackend/model/graph/GraphMessageTest.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb >> ackend/model/graph/GraphPersonTest.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/service/UserHandlerTest.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/GraphActivitySPITest.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/GraphActivityStreamSPITest.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/GraphAppDataSPITest.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/GraphFriendSPITest.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/GraphGroupSPITest.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/GraphMessageSPITest.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/GraphPersonSPITest.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb >> ackend/opensocial/spi/GraphSPITest.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb >> ackend/service/ActivityObjectServiceTest.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb >> ackend/service/ApplicationServiceTest.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb >> ackend/service/IDManagerTest.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb >> ackend/util/NodeFilterTest.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb >> ackend/util/NodeSorterTest.java >> PRE-CREATION >> >> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb >> ackend/util/PersonFilterTest.java >> PRE-CREATION >> /trunk/pom.xml 1452786 >> >> Diff: https://reviews.apache.org/r/9773/diff/ >> >> >> Testing >> ------- >> >> >> Thanks, >> >> René Peinl >> >> >
