I am trying to fix the JPA example but even the schema has changed since the last time any code is committed. Too much work to maintain this module when OpenSocial specs are moving as fast as it is right now.
I am proposing to dump this java-samples module because its getting harder to maintain. We will rely on unit tests and sample app using the JSON schema. - Henry On Fri, May 3, 2013 at 6:19 PM, Ryan Baxter <rbaxte...@apache.org> wrote: > I don't think so. I get test failures in that project not compile > errors. Although I just checked in changes for the compiler level to > move it to 1.6 so you might want to update and try again. > > On Wed, May 1, 2013 at 2:55 AM, Henry Saputra <henry.sapu...@gmail.com> > wrote: > > Hmm I got compile erro when tried to run mvn clean test in java/samples > dir: > > > > [ERROR] Failed to execute goal > > org.apache.maven.plugins:maven-compiler-plugin:2.3.2:testCompile > > (default-testCompile) on project shindig-samples: Compilation failure > > [ERROR] > > > /Users/hsaputra/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/integration/JpaRestfulTestConfigHelper.java:[83,11] > > cannot find symbol > > [ERROR] symbol : method setJSONPAllowed(boolean) > > [ERROR] location: class org.apache.shindig.protocol.DataServiceServlet > > [ERROR] -> [Help 1] > > [ERROR] > > > > > > Is this the same error? > > > > - Henry > > > > > > On Tue, Apr 30, 2013 at 5:23 PM, Ryan Baxter <rbaxte...@apache.org> > wrote: > > > >> Not really a blocker in my opinion, but I felt like we were close to > >> getting it in so I would at least try to make the effort ;) > >> > >> On Tue, Apr 30, 2013 at 1:32 PM, Henry Saputra <henry.sapu...@gmail.com > > > >> wrote: > >> > Ugh sorry for late reply. No I did not have time to look at it. > >> > > >> > I guess it is blocker for 2.5? I will take a look at it later today. > >> > > >> > > >> > - Henry > >> > > >> > > >> > On Fri, Apr 19, 2013 at 12:50 PM, Ryan Baxter <rbaxte...@gmail.com> > >> wrote: > >> > > >> >> Henry, have you had a sometime to look into this at all? Would like > >> >> to get this into 2.5. > >> >> > >> >> On Mon, Mar 18, 2013 at 2:38 PM, Ryan Baxter <rbaxte...@gmail.com> > >> wrote: > >> >> > Yes I just uploaded the newest patch from my workspace, if you > have a > >> >> > chance take a look at the samples module. I am just not familiar > >> >> > enough with JPA to know what is wrong... > >> >> > > >> >> > On Mon, Mar 18, 2013 at 2:26 PM, Henry Saputra < > >> henry.sapu...@gmail.com> > >> >> wrote: > >> >> >> I fixed couple issues before. So the patches for the udpated data > >> model > >> >> is > >> >> >> in that review entry? > >> >> >> > >> >> >> I can try it out. > >> >> >> > >> >> >> - Henry > >> >> >> > >> >> >> > >> >> >> On Mon, Mar 18, 2013 at 11:02 AM, Ryan Baxter < > rbaxte...@apache.org> > >> >> wrote: > >> >> >> > >> >> >>> Henry I actually have most of the 2 patches integrated together > [1]. > >> >> >>> I need to some help with the JPA stuff some of the unit tests are > >> >> >>> failing, are you familiar with that code at all? > >> >> >>> > >> >> >>> [1] https://reviews.apache.org/r/9990/ > >> >> >>> > >> >> >>> On Mon, Mar 18, 2013 at 1:46 PM, Henry Saputra < > >> >> henry.sapu...@gmail.com> > >> >> >>> wrote: > >> >> >>> > Yeah, I have been distracted with so many items so did not have > >> time > >> >> to > >> >> >>> > finish it =( > >> >> >>> > > >> >> >>> > Do you guys think it is a blocker for 2.5.0 release? > >> >> >>> > > >> >> >>> > > >> >> >>> > - Henry > >> >> >>> > > >> >> >>> > > >> >> >>> > On Sun, Mar 17, 2013 at 1:51 PM, Ryan Baxter < > >> rbaxte...@apache.org> > >> >> >>> wrote: > >> >> >>> > > >> >> >>> >> I dont think we have a list of them per-say. Looking through > the > >> >> >>> >> JIRAs labeled with 2.5.0 I found SHINDIG-1539 [1] which tries > to > >> few > >> >> >>> >> some gaps in the social data objects. I updated the patch > from > >> >> James > >> >> >>> >> so it builds against trunk and created a review for it [2]. I > >> think > >> >> >>> >> SHINDIG-1539 and SHINDIG-1878 are pretty much dups. We should > >> apply > >> >> >>> >> one of the reviews and close both of them. I am try and see > if > >> >> there > >> >> >>> >> are differences between the two. > >> >> >>> >> > >> >> >>> >> The other gap I can think of is the External Services section > in > >> the > >> >> >>> >> spec [3]. @Henry weren't you working on a patch for this? > >> >> >>> >> > >> >> >>> >> [1] https://issues.apache.org/jira/browse/SHINDIG-1539 > >> >> >>> >> [2] https://reviews.apache.org/r/9990/ > >> >> >>> >> [3] > >> >> >>> >> > >> >> >>> > >> >> > >> > http://opensocial-resources.googlecode.com/svn/spec/trunk/Core-Gadget.xml#ExternalServices > >> >> >>> >> > >> >> >>> >> On Sat, Mar 16, 2013 at 11:54 AM, Henry Saputra < > >> >> >>> henry.sapu...@gmail.com> > >> >> >>> >> wrote: > >> >> >>> >> > Not exactly, we have using JIRA to capture the differences. > >> >> Mostly the > >> >> >>> >> > differences come from the data model where new fields are > >> >> introduced > >> >> >>> or > >> >> >>> >> > have name changes. > >> >> >>> >> > > >> >> >>> >> > The big ticket AFAIK is SHINDIG-1878. > >> >> >>> >> > > >> >> >>> >> > I am +1 and reccommend for 2.5.0 release. It is been long > >> overdue > >> >> and > >> >> >>> >> > everybody have been putting a lot of good work. > >> >> >>> >> > > >> >> >>> >> > Thanks, > >> >> >>> >> > > >> >> >>> >> > Henr > >> >> >>> >> > > >> >> >>> >> > > >> >> >>> >> > On Sat, Mar 16, 2013 at 7:34 AM, Matt Franklin < > >> >> >>> m.ben.frank...@gmail.com > >> >> >>> >> >wrote: > >> >> >>> >> > > >> >> >>> >> >> On Saturday, March 16, 2013, Ryan Baxter wrote: > >> >> >>> >> >> > >> >> >>> >> >> > Hey everyone, > >> >> >>> >> >> > > >> >> >>> >> >> > 2.5.0-beta6 is out the door (thanks everyone for their > hard > >> >> work) > >> >> >>> and > >> >> >>> >> >> > I think we are at a point where 2.5.0 is pretty much > ready > >> for > >> >> a > >> >> >>> >> >> > release. Defects have been slow to come in over the past > >> few > >> >> weeks > >> >> >>> >> >> > and from my point of view things are pretty stable. I > know > >> >> there > >> >> >>> are > >> >> >>> >> >> > still some gaps between what is implemented in Shindig > and > >> >> what is > >> >> >>> in > >> >> >>> >> >> > the 2.5.0 OpenSocial spec > >> >> >>> >> >> > >> >> >>> >> >> > >> >> >>> >> >> do we at least have these gaps captured anywhere? > >> >> >>> >> >> > >> >> >>> >> >> > >> >> >>> >> >> > but I think it is also important to get a > >> >> >>> >> >> > non-beta release out there for other projects to consume. > >> If > >> >> >>> everyone > >> >> >>> >> >> > is OK with this our next release will be the official > 2.5.0 > >> >> release > >> >> >>> >> >> > and will not have a beta tag. > >> >> >>> >> >> > >> >> >>> >> >> > >> >> >>> >> >> > -Ryan > >> >> >>> >> >> > > >> >> >>> >> >> > >> >> >>> >> > >> >> >>> > >> >> > >> >
