> On Sept. 3, 2013, 1:19 a.m., Doug Davies wrote: > > Thanks for looking at this so quickly. My only comment would be should > > there be a unit test that shows the original problem and that this resolves > > it? Not sure how easy it would be to write a unit test that would cause the > > conflict. At any rate... looks good... until we upgrade again I will > > continue to use our patched EhCacheCacheProvider.
I'll think about how I can write some unit tests and get back to you. The easiest way would be to get the CacheManager object itself from the provider, but that's not supported today by the EhCacheCacheProvider. It's something I'll look into though. - Stanton ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13923/#review25842 ----------------------------------------------------------- On Sept. 1, 2013, 1:13 p.m., Stanton Sievers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13923/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2013, 1:13 p.m.) > > > Review request for shindig. > > > Bugs: SHINDIG-1931 > https://issues.apache.org/jira/browse/SHINDIG-1931 > > > Repository: shindig > > > Description > ------- > > Reported on the dev list[1]. The issue is that the > CacheManager.create(Configuration) APIs will always use the same singleton, > regardless of whether the provided Configuration defines a cache manager of a > different name then the existing singleton. We should use the > CacheManager.newInstance(Configuration) APIs, as this will use a singleton > per cache manager name. This will keep us from stomping on other cache > managers that exist in the environment. > > [1] > http://markmail.org/message/4adopzvvi3ltv7yq?q=Shindig+list:org.apache.shindig.dev+order:date-backward&page=1 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/ehcache/EhCacheCacheProvider.java > 1519267 > > Diff: https://reviews.apache.org/r/13923/diff/ > > > Testing > ------- > > Unit tests continue to pass. Shindig starts and samples load in the sample > container. > > > Thanks, > > Stanton Sievers > >
