----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15402/#review28712 -----------------------------------------------------------
I don't see in the spec where it says that passing an empty message collection should delete all messages. - Ryan Baxter On Nov. 11, 2013, 2:36 p.m., Andreas Kohn wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15402/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2013, 2:36 p.m.) > > > Review request for shindig. > > > Bugs: SHINDIG-1946 > https://issues.apache.org/jira/browse/SHINDIG-1946 > > > Repository: shindig > > > Description > ------- > > Call MessageService#deleteMessageCollection() from MessageHandler#delete() > when no message ids where specified. > > > Diffs > ----- > > > trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/MessageHandler.java > 1540645 > > Diff: https://reviews.apache.org/r/15402/diff/ > > > Testing > ------- > > Call method via REST, find that in the default sample application exception > about "unsupported" appears, rather than "no message ids specified." > > > Thanks, > > Andreas Kohn > >
