> On Nov. 12, 2013, 12:17 a.m., Ryan Baxter wrote: > > I don't see in the spec where it says that passing an empty message > > collection should delete all messages.
I'm not sure I'm following what you're saying here. The current code does not allow to be called without a message-collection-id (even though OS 2.5.1 says "optional", but the spec is horribly unclear what that would actually mean), and the patch isn't about 'empty message collection should delete all messages', but rather 'if no message-id is specified, then delete the collection with the name'. Again, the spec is unclear, and I think this should also be addressed on their side (currently working out how to send patches over there ...), but, my current reading is that: 1. DELETE <api>/messages/<user>/@self/<collection>/<message> would delete that specific message in the collection 2. DELETE <api>/messages/<user>/@self/<collection>/<multiple message ids> is no longer available in 2.5.1 (but shindig still can handle multiple message ids) 3. DELETE <api>/messages/<user>/@self/<collection> would delete the collection (no message id provided). The patch purely adds the support for the third case in the MessageHandler, putting the burden on the MessageService to implement this optional support for deleting message collections if it so intends. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15402/#review28712 ----------------------------------------------------------- On Nov. 11, 2013, 2:36 p.m., Andreas Kohn wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15402/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2013, 2:36 p.m.) > > > Review request for shindig. > > > Bugs: SHINDIG-1946 > https://issues.apache.org/jira/browse/SHINDIG-1946 > > > Repository: shindig > > > Description > ------- > > Call MessageService#deleteMessageCollection() from MessageHandler#delete() > when no message ids where specified. > > > Diffs > ----- > > > trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/MessageHandler.java > 1540645 > > Diff: https://reviews.apache.org/r/15402/diff/ > > > Testing > ------- > > Call method via REST, find that in the default sample application exception > about "unsupported" appears, rather than "no message ids specified." > > > Thanks, > > Andreas Kohn > >
