----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25650/#review56514 -----------------------------------------------------------
It looks like you're using 4 spaces instead of 2 spaces. Please use formatting that matches the surrounding code. trunk/features/src/main/javascript/features/core.io/io.js <https://reviews.apache.org/r/25650/#comment96880> Small nit: I'd prefer not to check specifically against the "undefined" keyword since it is not a restricted keyword and can be overwritten. Alternatively, checking typeof or params.hasOwnProperty() would suffice. - Stanton Sievers On Sept. 15, 2014, 7:19 p.m., Doug Davies wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25650/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2014, 7:19 p.m.) > > > Review request for shindig and Ryan Baxter. > > > Bugs: SHINDIG-1983 > https://issues.apache.org/jira/browse/SHINDIG-1983 > > > Repository: shindig > > > Description > ------- > > The NO_CACHE RenderParam does not appear to affect makeRequest. This fix adds > a NO_CACHE request param and if that's not defined then it tries to use the > NO_CACHE render param and if that's not defined then no caching occurs. > > > Diffs > ----- > > trunk/features/src/main/javascript/features/core.io/io.js 1625072 > trunk/features/src/test/javascript/features/core.io/iotest.js 1515531 > > Diff: https://reviews.apache.org/r/25650/diff/ > > > Testing > ------- > > I've tested the following scenarios > > renderParams[osapi.container.RenderParam.NO_CACHE] = true; (and false) > > and > > params[gadgets.io.RequestParameters.NO_CACHE] = 1; (and 0) > > and > > neither defined > > > Thanks, > > Doug Davies > >
