----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25650/ -----------------------------------------------------------
(Updated Oct. 14, 2014, 2:40 p.m.) Review request for shindig and Ryan Baxter. Changes ------- Fixed code review items. Added 1 new test. Bugs: SHINDIG-1983 https://issues.apache.org/jira/browse/SHINDIG-1983 Repository: shindig Description ------- The NO_CACHE RenderParam does not appear to affect makeRequest. This fix adds a NO_CACHE request param and if that's not defined then it tries to use the NO_CACHE render param and if that's not defined then no caching occurs. Diffs (updated) ----- trunk/features/src/main/javascript/features/core.io/io.js 1625072 trunk/features/src/test/javascript/features/core.io/iotest.js 1515531 Diff: https://reviews.apache.org/r/25650/diff/ Testing ------- I've tested the following scenarios renderParams[osapi.container.RenderParam.NO_CACHE] = true; (and false) and params[gadgets.io.RequestParameters.NO_CACHE] = 1; (and 0) and neither defined Thanks, Doug Davies