On Oct 23, 2010, at 10:29 AM, Kalle Korhonen wrote: > On Sat, Oct 23, 2010 at 8:24 AM, Alan D. Cabrera <[email protected]> wrote: >> Some comments. IMO, Shiro uses inheritance too much. It's a brittle >> practice that I think we're now starting to see the cracks; e.g. the >> conversion to use StringBuilder. >> It seems that are some hashing implementation details that have leaked into >> the abstract methods, i.e. hashing iterations. >> I'm not a fan of mixing data with code that manipulates it, e.g. the Hash >> hierarchy. Just a personal preference. Things start to end up looking like >> swiss army knives and Hash seems to be a good example. >> > > Agree - that's one of my pet peeves with Shiro as well, and especially > visible in the crypto/hash packages. Most of the code there is not > really required. Question is, when would be a good time to clean it > up? Perhaps for 1.2.
IMO, such a reorg should be 2.0. I would love to see a set of simple generics based interfaces with a modicum of POJOs fleshed out first and then implementations filled in afterward. Regards, Alan
