On Oct 23, 2010, at 2:15 PM, Les Hazlewood wrote:

> I just committed and resolved https://issues.apache.org/jira/browse/SHIRO-204
> 
> Please check it out and review.  Feel free to re-open the issue if
> I've missed anything.  All changes were 100% backwards compatible.
> Here's the commit log:
> 
> "committed implementation.  HashedCredentialsMatcher is now no longer
> abstract and all of its subclasses have been deprecated.  Introduced
> new SimpleHash implementation to allow ad-hoc hash algorithms to be
> used and all existing AbstractHash subclasses (Md5Hash, etc) have been
> updated to subclass SimpleHash instead of AbstractHash directly.
> AbstractHash has been marked deprecated."

So, all this "deprecation thrashing" is because of the extensive use of 
inheritance.

SimpleHash still suffers from the swiss army knife syndrome but the above work 
is a definite improvement.  Maybe there's a reason for doing it this way, 
bundling the  and I don't see it.


Regards,
Alan

Reply via email to