[
https://issues.apache.org/jira/browse/SHIRO-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15364618#comment-15364618
]
ASF GitHub Bot commented on SHIRO-337:
--------------------------------------
GitHub user bdemers opened a pull request:
https://github.com/apache/shiro/pull/24
WIP: CDI feature import SHIRO-337
I spent about a day looking into this, the original code was pretty good,
but I ran into a few issues when adding a sample project
Added CDI [README.md](support/cdi/README.md)
Added TODO's:
* [support/cdi](support/cdi/TODO.md)
* [samples](samples/cdi/TODO.md)
Comments above are just initial thoughts and are here to start discussion.
@hwellmann, I know it has been a while since you looked into this, but your
thoughts would be appreciated
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bdemers/shiro cdi-import
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/shiro/pull/24.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #24
----
commit daff202fe1a46141badcf73309d3237dcf4f8ef0
Author: Brian Demers <[email protected]>
Date: 2016-07-05T19:35:35Z
Initial CDI import
commit 8e40907d67e38b961ddffba7a2411bc8745f8139
Author: Brian Demers <[email protected]>
Date: 2016-07-05T19:38:53Z
renamed cdi packages after import
commit b806d61d40aad94db5e9f76b10e57d54cab8ba52
Author: Brian Demers <[email protected]>
Date: 2016-07-05T20:14:46Z
Replaced geronimo spec dependencies with javax equivalents
commit 4dfcbd0b770b2d45e8daf52f6ad80a26c9abb16b
Author: Brian Demers <[email protected]>
Date: 2016-07-05T20:33:06Z
Removed @author javadoc tags
commit 0200e716f2df8ad552bc852b356485696fae07a6
Author: Brian Demers <[email protected]>
Date: 2016-07-05T21:00:42Z
Updated license headers to match project
commit 8c380223fd8acc02f6d809a426e31079cd11c9c0
Author: Brian Demers <[email protected]>
Date: 2016-07-06T16:34:32Z
Attempting to add a CDI example from ops4j/org.ops4j.pax.shiro
original sample:
https://github.com/ops4j/org.ops4j.pax.shiro/blob/master/samples/sample-cdi-web
Added README.md from:
https://ops4j1.jira.com/wiki/display/PAXSHIRO/CDI+Support
Added TODO.md in support/cdi and samples/cdi with thoughts on the project
----
> adding support for CDI
> ----------------------
>
> Key: SHIRO-337
> URL: https://issues.apache.org/jira/browse/SHIRO-337
> Project: Shiro
> Issue Type: New Feature
> Components: Integration: JEE
> Affects Versions: 1.2.0, 1.2.1
> Reporter: Romain Manni-Bucau
> Priority: Critical
> Labels: patch, patch-with-test
> Fix For: 1.3.0
>
> Attachments: SHIRO-337-2.patch, SHIRO-337-3.patch, SHIRO-337.patch
>
>
> As there is a spring or guice integration, a CDI integration could be
> welcomed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
