[ 
https://issues.apache.org/jira/browse/SHIRO-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073401#comment-17073401
 ] 

Benjamin Marwell commented on SHIRO-588:
----------------------------------------

Hi [~bdemers]

I fiddled around a bit with DefaultLdapRealm, but it diverged a lot from the 
AbstractLdapRealm (strategies, Method naming, etc.).

I think the best shot were to create a new "DefaultLdapRealm" and to deprecate 
the old DefaultLdapRealm, but I cannot think of an approporiate name.

> DefaultLdapRealm should extend AbstractLdapRealm
> ------------------------------------------------
>
>                 Key: SHIRO-588
>                 URL: https://issues.apache.org/jira/browse/SHIRO-588
>             Project: Shiro
>          Issue Type: Improvement
>            Reporter: Brian Demers
>            Priority: Major
>             Fix For: 2.0.0
>
>
> DefaultLdapRealm not extending AbstractLdapRealm is confusing. If there is a 
> reason for it, we should add that do the javadoc.
> From: 
> http://shiro-user.582556.n2.nabble.com/Confused-By-Class-Hierarchy-tc7581289.html
> Note: this might not be a breaking change, as the API looks simliar (but 
> needs another look)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to