[ 
https://issues.apache.org/jira/browse/SHIRO-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17080440#comment-17080440
 ] 

Francois Papon commented on SHIRO-588:
--------------------------------------

The AbstractLdapRealm use a DefaultLdapContextFactory wich is deprecated and 
will be removed in 2.0.0.

We should replace it by JndiLdapContextFactory and make DefaultLdapRealm extend 
AbstractLdapRealm.

However I'm agree that the package/classes structure is confusing for users.

We have ActiveDirectoryRealm in a package activedirectory wich extend 
AbstractLdapRealm in package ldap...

We could merge some method from DefaultLdapRealm to AbstractLdapRealm.

[~bmarwell] why would you create a new DefaultLdapRealm ?

> DefaultLdapRealm should extend AbstractLdapRealm
> ------------------------------------------------
>
>                 Key: SHIRO-588
>                 URL: https://issues.apache.org/jira/browse/SHIRO-588
>             Project: Shiro
>          Issue Type: Improvement
>            Reporter: Brian Demers
>            Priority: Major
>             Fix For: 2.0.0
>
>
> DefaultLdapRealm not extending AbstractLdapRealm is confusing. If there is a 
> reason for it, we should add that do the javadoc.
> From: 
> http://shiro-user.582556.n2.nabble.com/Confused-By-Class-Hierarchy-tc7581289.html
> Note: this might not be a breaking change, as the API looks simliar (but 
> needs another look)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to